Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Unskip Transform continuous creation test #167829

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[ML] Unskip Transform continuous creation test #167829

merged 1 commit into from
Oct 4, 2023

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Oct 2, 2023 •
edited
Loading

Summary

Closes #158613
Closes #158612
Closes #165146
Closes #165144

Previous fix was skipped again due to timing. After some additional investigations, I believe that the flakiness should now be fixed.

Flaky test suite runner functional basic... successful after 100 runs ✅

Flaky test suite runner functional...successful after 150 runs ✅

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #13 / saved objects tagging - functional tests create tag show errors when the validation fails

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 self-assigned this Oct 3, 2023
@qn895 qn895 added the :ml label Oct 3, 2023
@qn895 qn895 added release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms labels Oct 3, 2023
@qn895 qn895 marked this pull request as ready for review October 3, 2023 17:19
@qn895 qn895 requested a review from a team as a code owner October 3, 2023 17:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87
alvarezmelissa87 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

peteharverson
peteharverson approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895 qn895 merged commit be7f34e into elastic:main Oct 4, 2023
7 checks passed
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@qn895 qn895

Labels
backport:skip This commit does not require backporting Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests Basic License - transform - creation - index_pattern.x-pack/test/functional/apps/transform/creation/index_pattern/continuous_transform·ts - transform basic license transform - creation - index pattern creation_continuous_transform continuous with terms+date_histogram groups and avg agg stops transform Failing test: Chrome X-Pack UI Functional Tests - transform - creation - index pattern.x-pack/test/functional/apps/transform/creation/index_pattern/continuous_transform·ts - transform - creation - index pattern creation_continuous_transform continuous with terms+date_histogram groups and avg agg stops transform Failing test: Chrome X-Pack UI Functional Tests Basic License - transform - creation - index_pattern.x-pack/test/functional/apps/transform/creation/index_pattern/continuous_transform·ts - transform basic license transform - creation - index pattern creation_continuous_transform continuous with the latest function runs the transform and displays it correctly in the job list Failing test: Chrome X-Pack UI Functional Tests - transform - creation - index pattern.x-pack/test/functional/apps/transform/creation/index_pattern/continuous_transform·ts - transform - creation - index pattern creation_continuous_transform continuous with the latest function runs the transform and displays it correctly in the job list
6 participants
@qn895 @kibana-ci @elasticmachine @alvarezmelissa87 @peteharverson @kibanamachine